Relationship issues

My husband and I have been married for 16 years. We are separated right now and I’m not sure if I should just give up. He is an extremely cranky person. Simple little things make him angry and he will stay that way for hours. We can’t even go shopping together because something little will make him mad and he will stay cranky. He also does not get along with my children 23 and 25. 23 has mental issues, is on SSDI, and lives with me. My husband is very mean to him and makes him feel uncomfortable being at home.

On the other side my husband is very good to me. He will even take care of me if I am sick in bed and can’t get up.